Skip to content

fix/integration-tests-identifier-vars#19

Merged
fivetran-joemarkiewicz merged 3 commits intomainfrom
fix/integration-tests-identifier-vars
Sep 8, 2025
Merged

fix/integration-tests-identifier-vars#19
fivetran-joemarkiewicz merged 3 commits intomainfrom
fix/integration-tests-identifier-vars

Conversation

@fivetran-joemarkiewicz
Copy link
Copy Markdown
Collaborator

PR Overview

Package version introduced in this PR:

  • v1.0.1

This PR addresses the following Issue/Feature(s):

  • Internal note to update for consistency

Summary of changes:

  • Issue where identifier variables were not declared in the integration_tests/dbt_project.yml file. This didn't result in any test issues, but for consistency across packages we should make sure the same structure is applied.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • No extensive testing or validation required. This is only an integration tests variable update that should have been included originally. Reviewing BK and confirming the models are running as expected should be sufficient validation/testing.
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-joemarkiewicz fivetran-joemarkiewicz self-assigned this Sep 2, 2025
@fivetran-joemarkiewicz fivetran-joemarkiewicz added the docs:ready Triggers the docs generator workflow. label Sep 2, 2025
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review September 2, 2025 14:48
Copy link
Copy Markdown
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread CHANGELOG.md
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 67242c4 into main Sep 8, 2025
9 checks passed
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the fix/integration-tests-identifier-vars branch September 8, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants